aemsites / vg-roadchoice-com

Road Choice website
https://www.roadchoice.com
Apache License 2.0
1 stars 0 forks source link

NFR: Update Sidekick Library #10

Closed ZoeBeykirch closed 6 days ago

ZoeBeykirch commented 2 months ago

Summary

Currently, when the content editor clicks on Library using AEM Sidekick, they are directed to a 404 error page.

Documenting the best practices in terms of the aspect ratio and min height of the assets we use on each block. This will be documented in the Franklin Library, on each block.

Acceptance criteria

Every block that can have an image added has the image requirements documented in the Franklin Library Requirements to be documented per brand

Priority

Medium

Description

This ticket aims to resolve the following issues:

  1. Fix the 404 Error: Ensure that the link to the Library is functional and directs users to the correct page.
  2. Library Update: Review and update all blocks within the Library to ensure they are current and functioning as expected.
  3. Documentation: Verify that all blocks meet Helix 5 requirements and that documentation is comprehensive and up to date in the library.
  4. Missing Blocks: Blocks that are currently missing from the library are added. Currently there is 15 on Sharepoint. 17 are missing as per https://ncchat.slack.com/files/U05TSR6AG58/F07TZHDEB8A/list-of-blocks.xlsx?origin_team=T04650MFY&origin_channel=C07KTUQ580P

Acceptance Criteria

Value creation

EX improvement

Cost of fixing

Low cost

Technical complexity

S

References

https://github.com/hlxsites/vg-macktrucks-com/issues/783 https://github.com/hlxsites/vg-volvotrucks-us/issues/662

santi-homps commented 2 weeks ago

After reviewing the complete repository and library I added all the missing blocks and the available list in the library is now the following:

Other blocks found but are not configurable and are not in the block library:

Other non-configurable blocks that are part of a template are: From part-category template:

  1. Category Filters
  2. Category Pagination
  3. Category Results List

From search-results template:

  1. Filters
  2. Pagination
  3. Results List

Blocks that were found in code but not implemented as far as I could find:

silviulungu commented 1 week ago

Testing completed. Everything works accordingly.