aemsites / vg-roadchoice-com

Road Choice website
https://www.roadchoice.com
Apache License 2.0
1 stars 0 forks source link

FR: [dealer-locator] - Make translations possible #36

Open cogniSyb opened 6 months ago

cogniSyb commented 6 months ago

Context/Description

Currently all content of the Dealer Locator is hardcoded. For market websites, we’d need translations.

Acceptance Criteria

User AC:

Editor AC:

Out of scope

Note

Possible blocker - need to get update on Helix 5 with Darin's assistance.

Technical details

No response

Attachment / link to Figma

https://main--roadchoice-mx--volvogroup.aem.page/ https://main--roadchoice-ca--volvogroup.aem.page/

BeckyMedlin commented 6 months ago

New markets need to be set up in Helix5 to enable this new enhancement.

BeckyMedlin commented 6 months ago

@janedbarra Would like to follow the lead of Volvo Trucks and Mack Trucks' market sites. @cogniSyb

mollyaljenkins commented 5 months ago

@BeckyMedlin as per @Kannan-CM translations and market folders are set up for CAN and MEX. We can now proceed with establishing RC market sites.

Kannan-CM commented 4 months ago

Hi @mollyaljenkins ,

Repos for Road Choice websites are ready:

https://main--roadchoice-mx--volvogroup.aem.page/ https://main--roadchoice-ca--volvogroup.aem.page/

ZoeBeykirch commented 4 months ago

Blocked - First need to meet with Darin and make sure the new RC language sites are published before estimating this task.

KJohnsn commented 4 months ago

Speaking with Santi and there are a number of issues with this ticket which will need to be discussed. From our chat, Santi mentioned the following: Ok so... as my understanding goes. -1: we should wait until we merge this issue from this sprint that should be done by friday since there are only some minor issues already in testing. -2: Syb mentions something about Darin implementing the helix V5 changes before we do this so that all 3 markets can be updated and avoid having to make these changes in all 3 repos. What are those changes, I do not know. -3: DL has a lot of text hardcoded in english. This should be tackled as a singular item since it will take some time. Another option is to have it in english for all sites until we spare some time to have it configured -4: This is maybe something to discuss as involves other brands as well, but I'm not sure if the solution of having all separate repositories is the correct one. I think that the idea was to have only one and then only make changes from the sharepoint. This would be beneficial in making all blocks available for all markets at once and also avoid having to sync every time we make changes. I know Syb was working towards making this possible but IDK where we are with it. Anyways... once those first 2 things are out of the way we could go on with this issue.

We will need updates from Darin re: implementing the helix v5 changes.

mollyaljenkins commented 3 months ago

Pending update post-helix 5 upgrade and release.

ZoeBeykirch commented 3 months ago

Janed confirmed this is not a Go-Live requirements and can be added to the Mexico/Canada sites as an enhancement

ZoeBeykirch commented 3 days ago

This should be addressed after the Road Choice Mexico market site has launched.

BeckyMedlin commented 3 days ago

To be planned as an enhancement in 2025.