aendue / ioBroker.reolink

Reolink adapter for ioBroker
MIT License
21 stars 9 forks source link

reolink has an invalid jsonConfig: #40

Closed ebgonline closed 6 months ago

ebgonline commented 7 months ago

Describe the bug
A clear and concise description of what the bug is. Errormessage from the admin-Adapter: reolink has an invalid jsonConfig: [{"instancePath":"/items/_options/items/cameraProtocol","schemaPath":"#/patternProperties/%5E.%2B/allOf/22/then/additionalProperties","keyword":"additionalProperties","params":{"additionalProperty":"newline"},"message":"must NOT have additional properties"},{"instancePath":"/items/_options","schemaPath":"#/properties/items/patternProperties/%5E.%2B/allOf/8/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match \"then\" schema"}]

To Reproduce
Steps to reproduce the behavior: Install reolink-Adapter Expected behavior
Camera is found and datapoints are filled

Screenshots & Logfiles
If applicable, add screenshots and logfiles to help explain your problem.

Versions:
starting. Version 1.0.1 (non-npm: aendue/ioBroker.reolink#42863bb6bd74194319503b855f95198849577cf9) in /opt/iobroker/node_modules/iobroker.reolink, node: v18.17.1, js-controller: 5.0.16

Additional context
Add any other context about the problem here.

oelison commented 7 months ago

I have tested it with a windows, linux and macOS. I have not seen this issue. How you did the installation? Did you compare the jsonConfig.json with the one from the repository?

ebgonline commented 6 months ago

I am happy with you, but how does this help? I didnt compare it, because it was installed from the github-repo and started.

ticaki commented 6 months ago

to check/reproduce this u need always the information about used admin version.

There is no error in ur jsonConfig.json

EDIT: this is a false positive schema check.

https://github.com/ioBroker/adapter-react-v5/issues/245

ticaki commented 6 months ago

Ups there is an error in Ur jsonconfig

newLine Not newline 😊

ebgonline commented 6 months ago

Thats funny, because i installed the adapter actually from github, where this was fixed before. now i get the log-entry from the reolink-adapter that says "TypeError [ERR_INVALID_URL]: Invalid URL: ERR_INVALID_URL" That i cant understand, because nowhere in the config is something like "URL" or so. My admin-Adapter is 6.12.0

oelison commented 6 months ago

I will change all newlines to newLines asap.

mcm1957 commented 6 months ago

@oelison Fixed with 1.0.2 or not?

ebgonline commented 6 months ago

fixed