search

aenix-io / etcd-operator

New generation community-driven etcd-operator!
https://etcd.aenix.io
Apache License 2.0
90 stars 13 forks source link

Replace extraArgs to be a list, not map #111

Closed kvaps closed 7 months ago

kvaps commented 7 months ago

As part of https://github.com/aenix-io/etcd-operator/issues/109

When specifying extraArgs for etcd, using a map presents no issues because the order of arguments is generally not significant; their sorting does not impact functionality (afaik).

However, when passing arguments to other components, their order can be crucial. This becomes important for the sidecar containers configuration which can run any software.

 spec:
-  extraArgs: # map[string]string
-    arg1: "value1"
-    arg2: "value2"
+  extraArgs: # []string
+    - --arg1=value1
+    - --arg2=value2
kvaps commented 7 months ago

We decided to rename it to options and use map for them, see #110