WIP: Refactoring certs and volumes for sts

aenix-io / etcd-operator

New generation community-driven etcd-operator!

https://etcd.aenix.io

Apache License 2.0

83 stars 14 forks source link

WIP: Refactoring certs and volumes for sts #169

Closed sergeimonakhov closed 3 months ago

sergeimonakhov commented 5 months ago

This pull request introduces code changes related to managing volumes for the STS object. Key modifications include the addition of structures to store certificate information and the definition of paths to certificate files. Additionally, changes have been made to the creation and mounting of the data volume for the ETCD container. These alterations aim to enhance certificate handling and data management within the controller's context.

sircthulhu commented 5 months ago

@sergeimonakhov Please run make lint-fix to resolve pre-commit errors and fix tests

sergeimonakhov commented 5 months ago

@sircthulhu I added even more refactoring and fixed the code to make the tests run. Overall, the base code was very poor; we need to be more stringent in our code reviews because it will become impossible to maintain if we keep accepting sloppy work.

kvaps commented 3 months ago

closed in favor https://github.com/aenix-io/etcd-operator/issues/224