update logging - Githubissues

aenix-io / etcd-operator

New generation community-driven etcd-operator!

https://etcd.aenix.io

Apache License 2.0

83 stars 14 forks source link

Closed aobort closed 3 months ago

aobort commented 3 months ago

Changes:

explicit flags to set logging level, logging level to attach stacktrace, development mode
explicit flag to disable webhooks
logging wrapper with zap & slog (might be reasonable to replace it with custom slog handler and remove zap in the future)
replace logr.V(N).* calls with more readable and clear wrapped log.Info(...), log.Debug(...) and log.Error(...)

Fixes: #208

Kirill-Garbar commented 3 months ago

Also could you please add comments to functions and methods? For now it is not clear from the first glance what are the functions for.