search

aeolus-incubator / tim

Web application for managing virtual images to be deployed in the cloud
www.aeolusproject.org
MIT License
3 stars 6 forks source link

Model associations and controllers #20

Closed mtaylor closed 12 years ago

jguiditta commented 12 years ago

Minor comments/correction aside, this looks great! Tests for me went down from 22 fails to 2, nice improvement. One more patch for ARes stuff, and we should be able to at least hook this into travis, if not merge into master (which I think we may be able to do). And just in case you had different results, my remaining 2 fails are:

rspec ./spec/models/target_image_spec.rb:52 # ImageManagement::TargetImage ImageFactory interactions Successful Requests should create new tar
get image with factory meta-data
rspec ./spec/models/provider_image_spec.rb:42 # ImageManagement::ProviderImage ImageFactory interactions Successful Requests should create new
 target image with factory meta-data
jguiditta commented 12 years ago

Ok, looks like agreed-on changes are here, tests still pass as before (modulo the 2 known issues), so ACK, merging