search

aeolus-incubator / tim

Web application for managing virtual images to be deployed in the cloud
www.aeolusproject.org
MIT License
3 stars 6 forks source link

Create target images api #8

Closed mtaylor closed 12 years ago

mtaylor commented 12 years ago

Added the ability to create target images.

This patch set contains APIs for:

Templates, BaseImage, TargetImage, ImageVersion.

This allows a client to build up an object graph finally resulting in a Target Image being created by Image Factory.

N.B. Create Target Image is not yet possible, ImageFactory V2 API is required

jguiditta commented 12 years ago

Couple general notes/questions here that don't apply to a single patch. I think, minor comments aside (and adding json back in), this looks good. However, I am curious why we need haml for an api-centric engine? Also, I'd really like to see proper api rdoc on these methods as they are created, going forward. For this rev, I would be ok with you pushing those later, when you get back from holiday, but this will be easier to use and maintain if we document it better from the beginning.

mtaylor commented 12 years ago

In response to your overall comment.

It's probably a personal preference but for me I prefer haml XML templating over something like html.erb. Less code and easier to understand. In addition, adding UI support was something I thought we had intentions for (albeit pretty low on the priority list).

You have a good point on maintaining documentation as we go along. As usual this was a second thought. I've added another RM task to document the API as it stands right now. Going forward we shall factor in time for documentation in planning.

https://www.aeolusproject.org/redmine/issues/3367