search

aeolus-incubator / tim

Web application for managing virtual images to be deployed in the cloud
www.aeolusproject.org
MIT License
3 stars 6 forks source link

rename ProviderImage attributes - provider_account_id, provider #81

Closed jprovaznik closed 11 years ago

jprovaznik commented 11 years ago

ProviderImage model usees provider_account_id to store provider_account_identifier key retreived from imagefactory (see populate_factory_fields method). Conductor associates ProviderImage with conductor's model ProviderAccount -> so we would ideally need provider_account_identifier for this association.

In worst case we could use other-then-default association attribute on conductor side but I would prefer to keep default attr names if possible.

Provider attribute doesn't confilct ATM, but could be potentially similar issue.

jprovaznik commented 11 years ago

Not sure how you mark blockers, bot this issue is blocker for 2.0 release.

morazi commented 11 years ago

Adding the 'blocker' label to this issue.

jprovaznik commented 11 years ago

Thanks for adding the label (I'm not a collaborator so I can't mark issues, I can only create them)

mtaylor commented 11 years ago

Closing this out. Since a pull request was created and accepted.