search

aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
950 stars 110 forks source link

[ENH] Naming of feature based collection transformers #1569

Open TonyBagnall opened 3 months ago

TonyBagnall commented 3 months ago

Describe the feature or idea you want to propose

we currently have four collection transformers that extract a vector of features. These are called

__all__ = [
    "Catch22",
    "TSFreshFeatureExtractor",
    "TSFreshRelevantFeatureExtractor",
    "SevenNumberSummaryTransformer",
]

The naming convention is not consistent. I think we should choose one way of doing it and use that.

Describe your proposed solution

three options are

  1. No suffix: Catch22, TSFresh, TSFreshRelevant
  2. CollectionTransformer suffix
  3. FeatureExtractor suffix

I dont mind which, but we should be consistent. Any thoughts?

Describe alternatives you've considered, if relevant

I could stop concerning myself with naming conventions :)

Additional context

No response

MatthewMiddlehurst commented 3 months ago

My preference is option 1. Should tidy up TSFresh at some point 🙂