aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
887 stars 94 forks source link

[BUG] Index out of bounds for new dictionary distances #1653

Closed MatthewMiddlehurst closed 1 week ago

MatthewMiddlehurst commented 2 weeks ago

Describe the bug

Based on the latest nightly CI run, the new distances for SAX/SFA from #1622 have an index out of bounds error.

They should also probably be in a submodule i.e. distances/symbolic/ or distances/dictionary/ since after a quick look they don't seems to take regular series input.

@patrickzib

Steps/Code to reproduce the bug

See https://github.com/aeon-toolkit/aeon/actions/runs/9492367012/job/26159387219#step:7:750

Expected results

Tests for new distances pass.

Actual results

Tests fail due to IndexError

Versions

N/A, see CI run.

MatthewMiddlehurst commented 1 week ago

Fixed by #1690