aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
887 stars 94 forks source link

[DEP] Deprecate BaseTransformer #1683

Closed TonyBagnall closed 1 day ago

TonyBagnall commented 2 weeks ago

last one out, turn off the lights, The whole lot will be removed, refactored or brushed under the carpet by release 0.11

aeon-actions-bot[bot] commented 2 weeks ago

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

MatthewMiddlehurst commented 1 week ago

Could you run one of the currently deprecated estimators and make sure there are not 2 warning printed because of this?

MatthewMiddlehurst commented 1 day ago

I'm going to propose we just roll this into v1.0.0 with one single package-wide deprecation message. Helps us avoid the above issue, and by that point hopefully it's just on its own with nothing using it.