aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
978 stars 116 forks source link

[ENH,BUG] LearnedShapelets interfaced functions #1687

Closed TonyBagnall closed 3 months ago

TonyBagnall commented 3 months ago

fixes #1387 by introducing a save_transformed_data parameter, same as RDST, then changing the contentious methods to get_transform and get_locations.

Also have some more testing, we should have 100% coverage of all shapelet classifiers except for MrSQM.

aeon-actions-bot[bot] commented 3 months ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$, $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.