Closed patrickzib closed 1 week ago
aeon
I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filespytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)maybe convert to a BaseSeriesTransformer at the same time (#1618)?
I was thinking about removing the Transformer all together and merge it into ClaSP Segmenter? :) Or should I convert it?
I was thinking about removing the Transformer all together and merge it into ClaSP Segmenter? :) Or should I convert it?
I meant merge the Transformer with the Segmenter, and remove the Transformer
I was thinking about removing the Transformer all together and merge it into ClaSP Segmenter? :) Or should I convert it?
I think remove the transformer and just merge it into a clasp segmenter is best way forward
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thank you @MatthewMiddlehurst and @TonyBagnall
I set n_jobs to 1 and have converted the BaseTransformer to a BaseSeriesTransformer for now.
Felt like merging everything into one module is also not the best option for now. Might re-consider this in the future :)
This is mostly a performance enhancement of the ClaSP implementation by: