search

aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
882 stars 93 forks source link

[BUG] Remove squaring distances in KNN regression #1697

Closed TonyBagnall closed 1 week ago

TonyBagnall commented 1 week ago

AS pointed out here https://github.com/aeon-toolkit/aeon/issues/1355

we square the weights of the distance functions in regression, but the are not sqrted see #669

squaring simply gives more influence to closer instances, much in the way HC2 weights. Its not necessarily wrong, but I dont think we should do it automatically. It will be a new issue to assess whether it makes a difference in performance.

fixes #1355

aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#7E0206}{\textsf{regression}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.