Closed TonyBagnall closed 1 week ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filespytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)@patrickzib @baraline how about this?
@patrickzib @baraline how about this?
Don't know much about the implications of initializing it like this, I thought you could do it at the start of _fit, but both should be somewhat similar I guess ?
@patrickzib @baraline how about this?
Don't know much about the implications of initializing it like this, I thought you could do it at the start of _fit, but both should be somewhat similar I guess ?
In Java this would be called once as a singleton first time an instance was created. If you do it in fit then you may as well use the numba version I implemented before.
just confirmed via the font of all knowledge:)
part of #1699 currently in minirocket we have two huge hard coded arrays in both fit and transform, this replaces both with a numba function to work out permutations.
Could instead replace by a function that returns the hard coded 84x3 array, but this will not be costly and its neater.