Closed TonyBagnall closed 3 months ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filespytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Is there a specific reason why you introduce two versions of fit/transform (multi, uni) ? Couldn't we use the multivariate code with n_channels=1
?
Otherwise, the rest looks good to me at first glance.
Is there a specific reason why you introduce two versions of fit/transform (multi, uni) ? Couldn't we use the multivariate code with
n_channels=1
? Otherwise, the rest looks good to me at first glance.
because its very complicated and I was looking for the simplest solution. Anything more can be done after imo. IIRC angus tried that but there were problems
Is there a specific reason why you introduce two versions of fit/transform (multi, uni) ? Couldn't we use the multivariate code with
n_channels=1
? Otherwise, the rest looks good to me at first glance.
I'll try it though .... seems to work! This code has sat here for two or three years :) I'll rerun with full coverage and testing
merge these two transformers, part of #1699, deprecate multivariate version
based on advice from @baraline, tried merging just using the multivariate version and it worked. Will explore any performance hit later. Prior to #1698, Minirocket and Minirocket multvariate were about 2000 lines long. After this PR combined both will be under 400 lines.
It could be done better, but at this point, with the issue #208 over a year old, I just want to move things forward.