search

aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
882 stars 93 forks source link

[ENH] Merge MultiRocket and MultiRocketMultivariate #1711

Open TonyBagnall opened 1 week ago

TonyBagnall commented 1 week ago

merges the two classes MultiRocket and MultiRocketMultivariate. Part of #1699 fixes #1713

Unlike minirocket, I will keep the transform functions within multirocket separate and raise an issue about how the multivariate version is implemented. I think

  1. it could be made more like the other rockets, but want to get the structure in place first.
  2. there is huge duplication between mini and multi rocket, which can be rationalised at a later date
  3. the random seed is set more often than needs be I think
review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.