search

aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
882 stars 93 forks source link

[BUG] Remove feature extraction from `TSFreshClusterer` #1716

Closed MatthewMiddlehurst closed 6 days ago

MatthewMiddlehurst commented 1 week ago

What does this implement/fix? Explain your changes.

This estimator has a parameter for feature extraction, which does not make sense for clustering. This currently breaks the estimator if toggled to true.

I don't believe this is released yet, and even if it is the code is broken anyway, so no deprecation issue IMO.

aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.