Open zy18811 opened 5 days ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filespytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)LGTM, but need the current test results used for comparison updated. This is all in
testing/
.If you need some help with this, let me know, I can get around to it eventually if you are busy.
Last commit should've now done this, please have a look and double check :)
Not blocking, but would be nice to convert it to SFA_FAST at some point, which is much faster.
Not blocking, but would be nice to convert it to SFA_FAST at some point, which is much faster.
maybe make an issue, same as with TDE?
Not blocking, but would be nice to convert it to SFA_FAST at some point, which is much faster.
Yeah, I did briefly look into doing this but ran into some numba weirdness so put it on the back burner for now.
I’ll make an issue like @TonyBagnall suggested.
@zy18811 if you need help with SFA_FAST in the future, drop me a message.
What does this implement/fix? Explain your changes.
Several small tweaks / fixes to REDCOMETS, improving performance.