Closed TonyBagnall closed 2 months ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#BCAE15}{\textsf{classification}}$ ], however some package labels are already present.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filespytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)Hi @TonyBagnall Regarding the input type, the latest mrsqm (0.0.7) supports numpy 3D so the conversion shouldn't be needed. Can I create another pull request to remove the conversion ?
@lnthach Hi Thach, I have done this as part of #1756 actually 🙂. Feel free to make your own PR if you want however as that has other stuff.
I saw that you had uploaded MrSEQL
to pypi so was interested in adding a wrapper for it, but was having a bit of trouble figuring out what parameters it has and what defaults I should set for them. Would you be able to help me with that?
fixes #1685 fixes #1738
currently MrSQM used the deprecated "nested_univ" internal type. In order to allow that to be removed, this PR moves the conversion from numpy 3D to pd.DataFrame with each cell a series to the only place its used, this function