[DEP] Deprecate the update function in BaseCollectionTransformer

TonyBagnall commented 3 days ago

BaseCollectionTransformer has a final method update that calls a private abstract method _update. This was bought over from the bad place, but the truth is there is not a single BaseCollectionTransformer that implements update, and its not really clear what it is meant to do. Resolves #1732

review-notebook-app[bot] commented 3 days ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aeon-actions-bot[bot] commented 3 days ago

Thank you for contributing to `aeon`

I have added the following labels to this PR based on the title: [ $\color{#312315}{\textsf{deprecation}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$, $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

[ ] Run pre-commit checks for all files
[ ] Run all pytest tests and configurations
[ ] Run all notebook example tests
[ ] Run numba-disabled codecov tests
[ ] Stop automatic pre-commit fixes (always disabled for drafts)

aeon-toolkit / aeon