aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
890 stars 93 forks source link

[BUG] Move reset #1751

Closed TonyBagnall closed 2 days ago

TonyBagnall commented 2 days ago

fixes #1750 with simplest solution

aeon-actions-bot[bot] commented 2 days ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

MatthewMiddlehurst commented 2 days ago

The metadata update should not really be happening in the first place. See https://github.com/aeon-toolkit/aeon/pull/1479 which disables it.

TonyBagnall commented 2 days ago

The metadata update should not really be happening in the first place. See #1479 which disables it.

dont actually agree with this, meta data storage should be possible when passed as kwargs to save time, useful with very large datasets, but Im ok to go with #1479 instead of this