aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.01k stars 118 forks source link

[BUG] Bounding window broken for certain distances #1861

Closed chrisholder closed 3 months ago

chrisholder commented 3 months ago

Describe the bug

Some of the distances have broken logic with the bounding matrix. The reason is due to the cost matrices being initialised to 0s instead of infinity like in DTW. Here is a list that need to be fixed:

Here is a visual example of the issue for msm image

As can be seen because the CM is initialised to 0s the min warping path will path to the edge of the window and follow it down.

Steps/Code to reproduce the bug

No response

Expected results

Add different logic for these distances for applying a window

Actual results

Screenshot above

Versions

No response

chrisholder commented 3 months ago

Closed as this is a duplicate issue I've moved this to a comment in that issue.