aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.01k stars 120 forks source link

[ENH,MNT] Adding Init saving for deep clustering module #1903

Open hadifawaz1999 opened 3 months ago

hadifawaz1999 commented 3 months ago

Describe the feature or idea you want to propose

Following the updates in #1826 , would be nice to have the same functionality and testing in the deep clustering module.

Describe your proposed solution

Describe alternatives you've considered, if relevant

No response

Additional context

No response

ghost commented 2 months ago

Hi! I'd like to work on this.

ghost commented 2 months ago

Aeon-Assign bot assign @neuron283

ghost commented 2 months ago

@hadifawaz1999 Where should I add the testing function for deep clustering? Under tests subdirectory there are 2 files: test_deep_clusterer_base.py and test_random_state_deep_learning_cluster.py

ghost commented 2 months ago

Also, the tests for classification and regression mentioned in #1826 are missing from latest version of aeon. It's a little confusing. Can you please elaborate?

hadifawaz1999 commented 2 months ago

the tests were moved into a new directory recently, @MatthewMiddlehurst could you give us an idea to where the new tests should go after the revamp we got in ?

MatthewMiddlehurst commented 2 months ago

If you want the test to run for each individual estimator, see the relevant yield file in testing/estimator_checking/. You will want to add a check there (or look at the functions there currently if just viewing).

Currently, clustering is being ported here #1877.

ghost commented 2 months ago

should I wait before clustering gets ported or just carry on and create a PR?

hadifawaz1999 commented 2 months ago

should I wait before clustering gets ported or just carry on and create a PR?

probably will be simpler i think yes