[MNT] Wrong type annotations for aeon classes

[SebastianSchmidl]

Describe the issue

We started to add Python type hints to our estimators. However, some existing hints for (Aeon) classes are incorrect, e.g.

https://github.com/aeon-toolkit/aeon/blob/be4af658d47526dad272e84a7d667b0a151383dd/aeon/classification/sklearn/_rotation_forest_classifier.py#L108-L110

• Type[BaseEstimator] references the type of the class (thus, estimatorFactory = BaseEstimator is of type Type[BaseEstimator])
• BaseEstimator references an instance of this class (thus, estimator = BaseEstimator() is of type BaseEstimator)
• more details about this destinction: https://mypy.readthedocs.io/en/stable/kinds_of_types.html#the-type-of-class-objects

Suggest a potential alternative/fix

Because the RotationForestClassifier works with an instance as base_estimator the correct type would be base_estimator: BaseEstimator

We need to check the code base for further such issues.

Additional context

No response

[SebastianSchmidl]

• [ ] https://github.com/aeon-toolkit/aeon/blob/be4af658d47526dad272e84a7d667b0a151383dd/aeon/regression/sklearn/_rotation_forest_regressor.py#L107
• [ ] check_random_state() also requires an instance of RandomState and not a class, e.g. https://github.com/aeon-toolkit/aeon/blob/be4af658d47526dad272e84a7d667b0a151383dd/aeon/classification/distance_based/_proximity_forest.py#L92 (and other locations)

[aryan0931]

i would like to work on this issue

[SebastianSchmidl]

Sure!

@aeon-actions-bot assign @aryan0931