aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
963 stars 112 forks source link

[ENH] Remove HC2 flag save_component_probas #2008

Closed TonyBagnall closed 3 weeks ago

TonyBagnall commented 3 weeks ago

Describe the feature or idea you want to propose

HC2 has the constructor option of whether to store components

        if self.save_component_probas:
            self.component_probas = {
                "STC": stc_probas,
                "DrCIF": drcif_probas,
                "Arsenal": arsenal_probas,
                "TDE": tde_probas,
            }

I dont really see the need for this option, unless there is a reason I am missing.

Describe your proposed solution

remove the parameter save_component_probas and always store in self.component_probas_ instead

Describe alternatives you've considered, if relevant

No response

Additional context

No response

TonyBagnall commented 3 weeks ago

oh hang on, component probas is not what I had assumed it to be