Closed SebastianSchmidl closed 1 month ago
Just wanted to get a feedback on how I plan to solve this problem:
IsolationForest
class inherited from PyODAdapter
IForest
from pyod
, then call super constructor.fit
, predict
and fit_predict
methods to call _fit
, _predict
and _fit_predict
from parent class respectively.get_test_params
method.Is there anything else you would like me to be aware about?
I am convinced that step 3 is not necessary.
The PyODAdapter
should already contain the logic required (anyway, please never override fit
, predict
and fit_predict
methods; estimators are just allowed to overwrite the _fit
, _predict
, and _fit_predict
methods).
No, just give it a shot, and we'll take a look at the PR afterward 👍🏼
Okay! Can you assign this issue to me?
@aeon-actions-bot assign notaryanramani
EXIT: hm, the bot seems to be broken 🤔
Describe the feature or idea you want to propose
The
PyODAdapter
in aeon allows us to use any outlier detector from PyOD, which were originally proposed for relational data, also for time series anomaly detection (TSAD). Not all detectors are equally well suited for TSAD, however. We want to represent the frequently used and competitive outlier detection techniques within theanomaly_detection
module of aeon directly.Implement the IsolationForest method using the
PyODAdapter
.Describe your proposed solution
aeon.anomaly_detection
for the methodPyODAdapter
as the parentExample for IsolationForest:
Describe alternatives you've considered, if relevant
No response
Additional context
No response