aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[ENH] Remove make_series from anomaly detection #2282

Closed TonyBagnall closed 2 weeks ago

TonyBagnall commented 3 weeks ago

part of #2281

anomaly detection tests were calling function to make a random numpy array. The function is legacy, and its not really required to create a random array

aeon-actions-bot[bot] commented 3 weeks ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$, $\color{#2C2F20}{\textsf{testing}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

MatthewMiddlehurst commented 3 weeks ago

This does not remove the function itself, but maybe that is best left to a separate PR.

TonyBagnall commented 3 weeks ago

This does not remove the function itself, but maybe that is best left to a separate PR.

that was my intention, yes, to keep it easier to review