Closed TonyBagnall closed 3 weeks ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
aeon
I have added the following labels to this PR based on the title: [ $\color{#F3B9F8}{\textsf{documentation}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$ ], however some package labels are already present.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filesmypy
typecheck testspytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)The phrasing is a bit weird here and got me confused :
We use 3D numpy even if the data is univariate: all classifiers work with shape (n_cases, n_timepoints), this can get confused with single multivariate time series, which are of shape (n_channels, n_timepoints).
Did you mean something like this?
We use 3D numpy even if the data is univariate: even though a univariate classifier could work using a 2D array of shape (n_cases, n_timepoints), this 2D shape can get confused with single multivariate time series, which are of shape (n_channels, n_timepoints). Hence, to differentiate both cases, we enforce the 3D format (n_cases, n_channels, n_timepoints) to avoid any confusion.
a few minor corrections