[ENH] Normalise/TimeSeriesScaler reconciliation

TonyBagnall commented 2 weeks ago

Reference Issues/PRs

Fixes #2075

Result of dev discussion at module meeting on 1/11/24. Removes the TimeSeriesScaler, replaced with three classes in the file _rescaler

Normalizer - maps all series onto N(0,1) Centerer- shifts all series to zero mean MinMaxScaler - Maps all series onto [0,1]

allows unequal length and multivariate (independent transform for each channel

[x] tests
[x] API
[x] notebook
[x] Refactor testing uses of TimeSeriesScaler to Normalizer

not doing here, but I think @dguijo may have wanted it

make invertible

aeon-actions-bot[bot] commented 2 weeks ago

Thank you for contributing to `aeon`

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

[ ] Run pre-commit checks for all files
[ ] Run mypy typecheck tests
[ ] Run all pytest tests and configurations
[ ] Run all notebook example tests
[ ] Run numba-disabled codecov tests
[ ] Stop automatic pre-commit fixes (always disabled for drafts)
[ ] Disable numba cache loading
[ ] Push an empty commit to re-run CI checks

review-notebook-app[bot] commented 2 weeks ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

TonyBagnall commented 2 weeks ago

i think would be nice to add visual examples of series normalized before and after, either unit tests datas or a non normalized ucr one

agreed, after #2279

MatthewMiddlehurst commented 2 weeks ago

Normalizer or Normaliser? We have other PRs changing to UK english.

TonyBagnall commented 2 weeks ago

Normalizer or Normaliser? We have other PRs changing to UK english.

which other PRs? I went Normaliser then realised the rest of the toolkit is US English

aeon-toolkit / aeon