Closed chrisholder closed 4 days ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filesmypy
typecheck testspytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
thanks Chris for taking care of this, however i think its best if we wait for the rest of the deep clustering prs to get in and make the deprecating changes here, if thats okay with you
btw @chrisholder n_clusters and clustering_params are also to deprecate in deep leaening (look at the warning you removed in base class)
Reference Issues/PRs
1518
This PR requires PR #2251
What does this implement/fix? Explain your changes.
This PR deprecates all the parameters and models for 1.0 release. Specifically it deprecates the following:
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access