aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[ENH]check for algorithm_type #2339

Closed aryanpola closed 1 week ago

aryanpola commented 1 week ago

Reference Issues/PRs

Fixes #1952

What does this implement/fix? Explain your changes.

Adds a check for algorithm_type in aeon.testing.estimator_checking._yield_classification_checks.py

For all contributions
aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

aryanpola commented 1 week ago

@MatthewMiddlehurst should I raise errors for the absence of the algorithm_type tag in the estimator?

TonyBagnall commented 1 week ago

@MatthewMiddlehurst should I raise errors for the absence of the algorithm_type tag in the estimator?

no, they do not have to have them, but if a classifier does have this tag, it should be one of {"convolution", "dictionary","distance", "feature", "shapelet", "interval","hybrid","deeplearning"}

thats all you need to check, thanks for your contributions