aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[ENH] Added OneClassSVM to the anomaly detection module #2342

Closed pattplatt closed 1 week ago

pattplatt commented 1 week ago

As discussed on friday, here is the implementation of the OneClassSVM for the Anomaly Detection module. Let me know what you think :)

What does this implement/fix? Explain your changes.

This PR includes the implementation of the OneClassSVM from scikit learn for anomaly detection.

PR checklist

For all contributions
For new estimators and functions
For developers with write access
aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

SebastianSchmidl commented 1 week ago

Please fix the line-length and run pre-commit locally again to address the CI failure in PR pre-commit:

flake8...................................................................Failed
- hook id: flake8
- exit code: 1

aeon/anomaly_detection/_one_class_svm.py:33:89: E501 line too long (110 > 88 characters)
pattplatt commented 1 week ago

I think the pre-commit was successful now 👍