aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[ENH] Port in multi comparison matrix into visualisation module #2343

Closed TonyBagnall closed 1 week ago

TonyBagnall commented 1 week ago

Fixes #1463

Ported in from https://github.com/MSD-IRIMAS/Multi_Comparison_Matrix

changes:

  1. I have made all the utility functions private and put them in the same file
  2. I have simply removed the soft dependency on baycomp and another on a progress bar. Latter is not needed. Former is not needed by me at the moment, and a new soft dep should be after some discussion.
  3. Removed parameters associated with bayesian things
  4. Changed default save_json to false
  5. Added minimal testing, probably needs more for coverage
  6. Added example at the end of examples/visualisation/plotting_results.ipynb
aeon-actions-bot[bot] commented 1 week ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ]. I would have added the following labels to this PR based on the changes made: [ $\color{#FBCA04}{\textsf{visualisation}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

TonyBagnall commented 1 week ago

@hadifawaz1999 feel free to jump in and make your changes