aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[BUG] Bug fix in SimpleImputer #2363

Closed notaryanramani closed 5 days ago

notaryanramani commented 5 days ago

Reference Issues/PRs

Fixes a small bug in SimpleImputer #2347 .

What does this implement/fix? Explain your changes.

In my previous PR #2347 , I accidentally did not notice a bug. When strategy is a callable, it was fitting on 2d array instead of 1d array of independent case. I was about to correct it but the PR got merged. This PR fixes that bug and includes a test case for it.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions
For new estimators and functions
For developers with write access
aeon-actions-bot[bot] commented 5 days ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.