aeon-toolkit / aeon

A toolkit for machine learning from time series
https://aeon-toolkit.org/
BSD 3-Clause "New" or "Revised" License
1.02k stars 128 forks source link

[BUG] Fixed Bug for negative values for scatter plot #2364

Closed kavya-r30 closed 3 days ago

kavya-r30 commented 5 days ago

Reference Issues/PRs

Fixes #2270

What does this implement/fix? Explain your changes.

Scaling of the minimum and maximum values by 0.97 and 1.03 is intended to provide a padding around the data range. However, if the data includes negative values (like -0.324397), the scaled minimum (min_value) will be closer to zero when multiplied by 0.97 thereby making it removing itself from the plot range. Therefore to resolve this we can multiply the negative values by 1.05 for min_values and 0.95 for max_values thereby making all points visible in the plot

Result: aeon_scatter

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

PR checklist

For all contributions
For new estimators and functions
For developers with write access
aeon-actions-bot[bot] commented 5 days ago

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#FBCA04}{\textsf{visualisation}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.