[ENH] Refactor num_kernels

TonyBagnall commented 1 day ago

taking the opportunity of V1.0 to refactor all the rocket related estimators to use n_kernels instead of num_kernels.

I have also removed the transformer MiniRocketMultivariateVariable. It handled unequal length in an unapproved, unpublished way and is I feel legacy code.

closes #1699 There are other things in 1699, but I think a new issue is better for the actual improvements/changes. This is the tidying up finished for me

review-notebook-app[bot] commented 1 day ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aeon-actions-bot[bot] commented 1 day ago

Thank you for contributing to `aeon`

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

[ ] Run pre-commit checks for all files
[ ] Run mypy typecheck tests
[ ] Run all pytest tests and configurations
[ ] Run all notebook example tests
[ ] Run numba-disabled codecov tests
[ ] Stop automatic pre-commit fixes (always disabled for drafts)
[ ] Disable numba cache loading
[ ] Push an empty commit to re-run CI checks

hadifawaz1999 commented 4 hours ago

yup it should also be n_kernels for the gpu one

aeon-toolkit / aeon