Open MatthewMiddlehurst opened 20 hours ago
aeon
I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ]. I have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit
code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeon
Slack channel if you have any.
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
pre-commit
checks for all filesmypy
typecheck testspytest
tests and configurationscodecov
testspre-commit
fixes (always disabled for drafts)
Final part of AEP 05. As far as I know.
For the most part the all-estimator checks were mostly good, but could use some tidying. Some tests i merged to reduce
fit
calls and to reduce redundancy.check_fit_updates_state
now also checks cloning, to avoid having to fit just to check clone resetsis_fitted
check_set_params
had two tests essentially with a bit of redundancy, these have been mergedcheck_constructor
has the most confusing changes probably. It should mostly the same except all kw params are tested and allcallable
parameters are now allowed as defaults (matching sklearn)