[MNT] Deprecation of old ShapeDTW classifier

aeon-toolkit / aeon

A toolkit for machine learning from time series

https://aeon-toolkit.org/

BSD 3-Clause "New" or "Revised" License

1.01k stars 120 forks source link

[MNT] Deprecation of old ShapeDTW classifier #788

Closed hadifawaz1999 closed 5 months ago

hadifawaz1999 commented 1 year ago

Describe the issue

After having ShapeDTW in the distance module (see #754 ) , the old ShapeDTW classifier can be deprecated given its KNN couple with ShapeDTW.

The implementation supposes that shapeDTW with knn is simply knn-dtw on transformed series, this is false.

Suggest a potential alternative/fix

When deprecation policy is back we can take care of this before releasing v0.9.0

Additional context

No response

TonyBagnall commented 1 year ago

we should also consider whether to deprecate all the associated transformers that are used here and no where else. I have no real strong feeling either way, but we should discuss it

TonyBagnall commented 5 months ago

this is done