search

aeon0 / d4lf

Diablo 4 Loot Filter
MIT License
154 stars 38 forks source link

Add favourites to move items type. #332

Closed suchyindustries closed 2 months ago

cjshrader commented 2 months ago

I'm not sure what the use case is for this, but at the same time I don't see how more options hurt anyone.

Can you put the enum in alphabetical order? I know @chrisoro likes to keep it that way to make them easier to read (so put favorites after everything).

Also could you update the readme with this new option?

cjshrader commented 2 months ago

this looks good to me, but I don't have final approval of course.

suchyindustries commented 2 months ago

I'm not sure what the use case is for this, but at the same time I don't see how more options hurt anyone.

Can you put the enum in alphabetical order? I know @chrisoro likes to keep it that way to make them easier to read (so put favorites after everything).

Also could you update the readme with this new option?

Personally, I missed favourites option from start of this feature. Move junk to inventory (to sell or salvage), and move favourites to stash (keep them for market or alt)