search

aeon0 / d4lf

Diablo 4 Loot Filter
MIT License
167 stars 41 forks source link

Added default minpower to importers #352

Closed cjshrader closed 2 months ago

chrisoro commented 2 months ago

I get why you added this but the value makes 0 sense and is now always annoying. I would say if you want a template to edit for later, just enable full_dump. What do you think?

cjshrader commented 2 months ago

I think full_dump is a bit overwhelming for most people, it adds way more information than they need. I think minPower is the #2 thing people will tweak over time as they get better gear, after the values for the actual affixes. It just makes sense to me to always be there.

We could ask in discord to see how people feel about it? We could make it configurable but honestly we have a million configurations already and I was avoiding adding another when someone can do a simple replace all on this one.

chrisoro commented 2 months ago

Sure we can ask but I think minPower is super irrelevant. For leveling, it doesn't matter since it is easy anyways. For endgame you only really care for weapon ilvl. For everything else the stats are most important. And then you are at a point where only 925 frops anyways 🤷

cjshrader commented 2 months ago

I just don't see what it hurts to have it, and it gives a minor improvement to people especially while leveling.