aeon0 / d4lf

Diablo 4 Loot Filter
MIT License
154 stars 38 forks source link

Filter Affixes not working #359

Closed tikalein closed 3 weeks ago

tikalein commented 1 month ago

`- Amulet: affixPool:

Both items are redflagged

image

2024-08-14 | 15:51:54.511 | ThreadPoolExecutor-0_0 | WARNING | src.item.descr.find_affixes:125 | Affix does not exist: cleaned_str='critical strike damage skills deal up to increased damage based on your available primary resource when cast, receiving the maximum benefit while you have full primary resource.' ||| combined_lines='+96.0% critical strike damage [80.0 - 100.0)% skills deal up to 16%[x] [10 - 40]% increased damage based on your available primary resource when cast, receiving the maximum benefit while you have full primary resource. requires level 80 sorcerer sell value: 103,174 durahilite 100100,'

There might be more bugs regarding affixes Version 5.7.3

chrisoro commented 4 weeks ago

Can you provide the first two images without our tool overlay?

tikalein commented 4 weeks ago

image image

chrisoro commented 4 weeks ago

Thank you. I won’t be at my PC until Sunday, but please try out version 5.7.4 and see if it helps. A user on Discord confirmed that it works for 1080p with small and medium settings.

tikalein commented 4 weeks ago

image `- ChestArmor: affixPool:

Still not working in 5.7.5

I like to help is there a debug mode ?

chrisoro commented 3 weeks ago

The item is detected properly in 5.7.5.

tikalein commented 3 weeks ago

image Correctly filtered in 5.6.4 image not filtered in 5.7.5

Is there a way to dump the ocr results just to see if its a ocr problem or the bug is elsewhere ?

chrisoro commented 3 weeks ago

We can run our detection on a screenshot, that is what I have done to verify it working in 5.7.5

chrisoro commented 3 weeks ago

multi lines should be fixed with 5.7.6

tikalein commented 3 weeks ago

image

still red bordered in 5.7.7 while correctly green in 5.6.4

chrisoro commented 3 weeks ago

I just ran it and the detection is 100%. image

So it can't be a detection issue. What is your filter?

tikalein commented 3 weeks ago

how can it get your screen ?

the filter is:

`- Staff: affixPool:

but i the filter works in 5.6.4 so i would say the yaml.file is fine

chrisoro commented 3 weeks ago

how can it get your screen ?

I ran our code from source as debug. No other easy way.

the filter is:

- Staff: affixPool: - count: - {name: intelligence} - {name: critical_strike_damage} - {name: maximum_life} minCount: 2 minGreaterAffixCount: 1 itemType: [staff]

but i the filter works in 5.6.4 so i would say the yaml.file is fine

can you format it correctly or upload the file to pastebin? indentation is important.

tikalein commented 3 weeks ago

image the code is created by the gui

chrisoro commented 3 weeks ago

It is detected and filtered correctly. No idea why it isn't working on your end :(

tikalein commented 3 weeks ago

That's why i asked how to debug it, i use Visual Studio but in C++/C#. I am doing my best to set it up for python

chrisoro commented 3 weeks ago

Can you send me a full screenshot where you are hovering over the item? Without d4lf running of course. Btw hop into our discord, easier to chat ;)

tikalein commented 3 weeks ago

image i am in the discord :-)

chrisoro commented 3 weeks ago

As discussed, increasing resolution and/or quality solved the issue