aeon0 / d4lf

Diablo 4 Loot Filter
MIT License
167 stars 41 forks source link

Items with correct stats are marked as junk #388

Open n4ks opened 2 weeks ago

n4ks commented 2 weeks ago

Hello. I imported this build https://maxroll.gg/d4/build-guides/stinger-spiritborn-guide

For example, the build uses staffs with the following stats:

image

I have a staff with the following stats:

image

When filtered, it is marked as trash and highlighted with a red border, even though 3 out of 3 stats are prioritized by the guide.

chrisoro commented 2 weeks ago

Can you upload a screenshot of the item without our tool running? I also need the resolution and font size

n4ks commented 1 week ago

Sure.

image image image

Resolution: 2560*1440 Font scale: medium

Revelstok commented 1 week ago

My wife and I both have an issue with quarterstaffs being marked as junk too. Hers is marked as junk, and mine is only showing an aspect that updates the codex. Everything else works fine though.

My resolution is 1920x1080 and my font scale is small. I've included a screenshot of my item.

Revelstok commented 1 week ago

Hello, I figured it would be helpful for you so I've included a second example. This time the problem is with pants. When I have minGreaterAffixCount set to 1, the pants are marked as junk. When I have minGreaterAffixCount set to 0, it recognizes the pants.

pants greater affix 0 pants greater affix 1

Revelstok commented 1 week ago

Sorry, I'll post this last one. I know it's useful to have as much data as possible. If you have enough, I'll stop posting. Armored hide doesn't seem to be recognized for myself and my wife too. However, on one piece of her gear it marked "armored hide" as a green affix, but she was only looking for "to armored hide":

armored hide

chrisoro commented 1 week ago

re quarterstaff: Quarterstaff is fixed in 5.8.5

re armored hide: still open

re your pants: is the option for gas in the group or on item level?

Revelstok commented 1 week ago

Awesome, thank you! Nice job.

re quarterstaff: Quarterstaff is fixed in 5.8.5

re armored hide: still open

re your pants: is the option for gas in the group or on item level? - I'm sorry, I don't quite understand what you're asking here. What is "gas" and are you referring to my config?

chrisoro commented 1 week ago

greater affix ;) You can specify it on the count group (= one of specified affixes must be greater) or on item level (= one of the items affixes must be greater)

Revelstok commented 1 week ago

greater affix ;) You can specify it on the count group (= one of specified affixes must be greater) or on item level (= one of the items affixes must be greater)

Sorry, I must not be understanding part of what you're asking. I pasted what the config looked like. If I specified level 800 with 0 greater affixes it would mark it as green (valid). If I changed it to 1 affix or more must be greater, it marked them as red. I don't have those pants anymore so I can't re-create it but I can try if I find some more.

This works: Legs: affixPool:

count:
    {name: armor}
    {name: maximum_life}
    {name: resistance_to_all_elements}
    minCount: 2
    minGreaterAffixCount: 0
    itemType: [pants]
    minPower: 100

This did not work: Legs: affixPool:

count:
    {name: armor}
    {name: maximum_life}
    {name: resistance_to_all_elements}
    minCount: 2
    minGreaterAffixCount: 1
    itemType: [pants]
    minPower: 100
chrisoro commented 1 week ago

Please send me an image and the exact filter if you encounter this again. The armor and to_armored_hide will be fixed with 5.8.7