search

aeonix / aeonix.github.io

AEON website
7 stars 24 forks source link

multi-page layout #115

Closed aeon1234 closed 3 years ago

aeon1234 commented 3 years ago

preview https://aeon1234.github.io/

ghost commented 3 years ago

It is a good start and works for now. I would like this better if there were truly multiple pages and not css tricks. That way if the website is to grow larger in the future the entire website does not need to be downloaded at one time. You will need multiple layouts in _layouts see https://jekyllrb.com/docs/pages/

ghost commented 3 years ago

https://jekyllrb.com/docs/layouts/

aeon1234 commented 3 years ago

I'm not sure right now how we can solve this in a halfway elegant way with our current messy implementation of translation. that's why I did it that way for now. any idea?

ghost commented 3 years ago

I understand your concern. This is the point I make about starting from scratch. It sounds like we should fix translation before moving forward. Otherwise, the website will continue to become more confusing and harder to work with.

BigslimVdub commented 3 years ago

IMO the translations are quite easy to do right now since everything is in one file and grouped together. One can easily add a new language with editing 3 files and making a pr

aeon1234 commented 3 years ago

I said that it's messy because without language plugin we currently have to add way more files in a real multi-page layout (exactly one file for each page and each language; at least as far as I can see). but I will have a look at this again and hopefully come with a better solution.

ghost commented 3 years ago

@bigslim That is nice for now, I agree, but having everything in one giant file is not an organized/quick approach. It is also not extendable. Every page of the entire website will have to be in one file content.html and will be loaded when visited. It will work but it will be slow and rely on css+javascript instead of using jekyll tools that are already available to us for multi pages and translations.

If this is okay for everyone, I am happy to approve but it is not the way of the future. Eventually this will have to be redone.

ghost commented 3 years ago

@aeon1234 is there somewhere we can preview these changes? I would like to see how it is to use.

ghost commented 3 years ago

Also, can you add information to the read me about how to add a new page or remove a page that is no longer needed?

SomaticFanatic commented 3 years ago

I think this change is unneeded. People on their phones are much much more likely to keep scrolling to look at more content than to click the hamburger icon to click on additional pages.

aeon1234 commented 3 years ago

@ivoryguru I added a preview link on top comment. but usually it's best to download PR and test locally. @SomaticFanatic i can only speak for myself here, but i would like to see and also add more content to the website and don't think we need an even longer scrollbar. however, i think the mobile menu could use some reworking (especially in terms of size of links) to make it easier to use. that's why i think this PR is a good start in the right direction for now.

ghost commented 3 years ago

@aeon1234 thanks. It is a good start but like I was saying, if we are building for the future it will need to be multiple pages. Transitions between pages are already very slow so I cannot approve this PR. If you want to go through the trouble to make multiple layouts, I won't stop you; but, it is already finished at https://github.com/ivoryguru/aeon-crypto so feel free to fork and modify as you please. I know you are all stubborn for change but I am really trying to do some good for everyone so please be open for change.

aeon1234 commented 3 years ago

the survived scroll animation had an unwanted behavior (it was always on for 1 second). i have adjusted it a bit and now there should be no more lags when trying to scroll manually after clicking a menu item. please try the preview again.

otherwise this way of loading and displaying is a bit faster than reloading single pages from the server/cache every time. of course everything is loaded the first time but that's what it does on the current live page as well.

ghost commented 3 years ago

Much better.. I thought that was strange

ghost commented 3 years ago

Does that need another commit or is it here already?

aeon1234 commented 3 years ago

updated commit (after messing around :laughing:)

ghost commented 3 years ago

This is working much better. Is there anything else we need to add to this or are we just going for the multi-page functionality @SomaticFanatic

SomaticFanatic commented 3 years ago

As stated earlier, I think this change is a negative one. Longer scroll is better than multiple pages for phones. A lot of normies don’t even click on hamburger icons.

ghost commented 3 years ago

Haha that is a good point, it is possible to maintain a longer front page still. I believe the goal for this is to only set up the functionality for multipages so possibly @aeon1234 will have to comment, they are building a better code for this I believe.

aeon1234 commented 3 years ago

i don't see any other way than splitting the website to create some order and add more content in the long run. for example there are links to exchanges and a part of the community pages in the footer. first of all that rather doesn't belong there and secondly you can hardly add more links and categories to keep it from getting completely overcrowded. and unfortunately you have the same problem with the other categories too without the website being as long as a book afterwards.

unless of course no one wants to add anything more to the website then it can stay that way. but that's not my goal. besides most websites have a menu. if normies don't click on it they miss half the internet.

ghost commented 3 years ago

Something might be possible, but first we would need to have the pages to work with. Have you made any progress on that front?

aeon1234 commented 3 years ago

should be finished. preview updated.

ghost commented 3 years ago

Nice, this is really well done. It is perfect. I think now is a good time to discuss some of what @SomaticFanatic writes. For example, features section may be fine staying together on the first page. Not enough content for standalone page. I made a PR on your branch if it is desired.

Also will want to think about what to do with footer.

aeon1234 commented 3 years ago

I made a PR on your branch if it is desired.

I think we should keep these two PRs separate. but I am open to a discussion. so it would be great if others could give their opinion on this.

and I agree that we can include the content of features in home page as long as it doesn't contain more content.

ghost commented 3 years ago

Ok, I don't see what harm it would cause but that is fine to make a seperate PR too.

ghost commented 3 years ago

@aeon1234 told me that they are working to combine features and differences into the home page.