aeosynth / bk

Terminal Epub reader
MIT License
262 stars 17 forks source link

Error for a specific epub #25

Closed akito-sama closed 1 year ago

akito-sama commented 1 year ago

i recently when playing around with bk encountering a mysterious bug:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnknownEntityReference("rsquo", TextPos { row: 12, col: 36 })', /home/kaito/.cargo/registry/src/github.com-1ecc6299db9ec823/bk-0.5.3/src/epub.rs:57:63
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace .

i though first that the problem was coming from the epub which may be corrupted, but i found that it can be read with other terminal reader like epr i really like this project and i want to use it to read epub, but this limitation makes it harder to use

aeosynth commented 1 year ago

that's an issue with the xml library. see #13 and

https://github.com/aeosynth/bk/blob/61beded518e759884d72732a068744935c11ea6f/src/epub.rs#L56-L57

i could add a note to that error, that it's a known issue

i though first that the problem was coming from the epub which may be corrupted

the issue is with the epub, but other readers may have more lenient parsers.