Adopt AEP-126 - Githubissues

aep-dev / api-linter

A linter for APIs defined in protocol buffers.

Apache License 2.0

0 stars 1 forks source link

Adopt AEP-126 #52

Closed rambleraptor closed 5 months ago

rambleraptor commented 6 months ago

Fixes #7

This has the following changes:

Removes upper_snake_case since this is not a strict requirement anymore.

toumorokoshi commented 5 months ago

is the strategy to remove SHOULD rules? I thought there was going to be some way to select should vs must.

rambleraptor commented 5 months ago

Yep, there absolutely is! This was a old PR before we established that rule. I'll get this updated and send it back out for review.

The proper path forward is to have linter rules for should + must. Must rules cannot be disabled via comments, where should lines still can.

rambleraptor commented 5 months ago

Actually, I lied! We changed the AEPs so that you must use "a consistent case", as opposed to strictly upper_snake_case. This was a very purposeful deletion!