search

aequitas / concourse-http-api-resource

Concourse resource to allow interaction with (simple) HTTP API's.
https://hub.docker.com/r/aequitas/http-api-resource/
MIT License
25 stars 18 forks source link

Fix for aequitas/concourse-http-api-resource#8 #11

Closed pranaysharmadelhi closed 6 years ago

pranaysharmadelhi commented 6 years ago

Fix for aequitas/concourse-http-api-resource#8 Replace null version with a hardcoded ref:none to prevent Concourse UI from crashing

aequitas commented 6 years ago

Thanks for contributing. Like @scottasmith suggested could you run the test suite to make sure everything passes?

Also why return "none" instead of for example null. Does "none" have any special value? As I understand it this will create a new version when there isn't one which might not be desirable effect.

aequitas commented 6 years ago

I added Travis support for this repo, if you rebase it on the latest master and force push the update it should run the automated tests as well.

scottasmith commented 6 years ago

No reason to return "none" in the version. As long as concourse doesn't blow up it could be anything