search

aequitas / concourse-http-api-resource

Concourse resource to allow interaction with (simple) HTTP API's.
https://hub.docker.com/r/aequitas/http-api-resource/
MIT License
25 stars 18 forks source link

Feature to fetch resource #3

Closed msiebeneicher closed 6 years ago

msiebeneicher commented 7 years ago

This PR will add the possibility to use the http-api resource also as "get" resource for tasks. The api response can be found under "/response.json" in the task container.

In my use case the updated version works as expected. If you want to test the implementation you can reuse my docker image if you want:

docker push msiebeneicher/concourse-resources:http-api-resource-dev
aequitas commented 6 years ago

Sorry for my late reply, I haven't been monitoring this repo for a while.

I rebased your branch on the latest master and it seems to work fine. Only thing I'm puzzled about is why you use the generate_hash on the check? I'm a little out of touch with concourse, but I think it goes against common convention to create implicit versions based on timestamp. Also because it always gives a response if there is nothing to check. Maybe it would be better to hash the response itself instead of a timestamp?

msiebeneicher commented 6 years ago

To be honest: i have no idea anymore what I was thinking of a year ago ;)

I'm a little out of touch with concourse

Same for me - i personally not working on concourse anymore at the moment.

Feel free to update this PR if you want to use it - otherwise it's also fine for me to close it

aequitas commented 6 years ago

No problem, I'll close it then.