search

aerdem4 / lofo-importance

Leave One Feature Out Importance
MIT License
810 stars 83 forks source link

LOFOImportance accepts groups params for GroupKFold cv #57

Closed kingychiu closed 5 months ago

kingychiu commented 7 months ago

The groups param is passing to sklearn.model_selection.cross_validate directly

aerdem4 commented 5 months ago

Sorry for my very late response. Would you consider renaming groups to something like cv_groups? Because groups is clear when function is named cross validate but not that clear for LOFO class.

kingychiu commented 5 months ago

Hi @aerdem4, updated the name. The goal of this change is really want to have groupkfold here.